monorepo/cloud/maplefile-backend/internal/service/collection/update.go

240 lines
7.8 KiB
Go

// monorepo/cloud/backend/internal/maplefile/service/collection/update.go
package collection
import (
"context"
"time"
"go.uber.org/zap"
"github.com/gocql/gocql"
"codeberg.org/mapleopentech/monorepo/cloud/maplefile-backend/config"
"codeberg.org/mapleopentech/monorepo/cloud/maplefile-backend/config/constants"
"codeberg.org/mapleopentech/monorepo/cloud/maplefile-backend/internal/domain/crypto"
dom_collection "codeberg.org/mapleopentech/monorepo/cloud/maplefile-backend/internal/domain/collection"
"codeberg.org/mapleopentech/monorepo/cloud/maplefile-backend/pkg/httperror"
"codeberg.org/mapleopentech/monorepo/cloud/maplefile-backend/pkg/ratelimit"
)
type UpdateCollectionRequestDTO struct {
ID gocql.UUID `json:"id"`
EncryptedName string `json:"encrypted_name"`
CollectionType string `json:"collection_type,omitempty"`
EncryptedCollectionKey *crypto.EncryptedCollectionKey `json:"encrypted_collection_key,omitempty"`
Version uint64 `json:"version,omitempty"`
}
type UpdateCollectionService interface {
Execute(ctx context.Context, req *UpdateCollectionRequestDTO) (*CollectionResponseDTO, error)
}
type updateCollectionServiceImpl struct {
config *config.Configuration
logger *zap.Logger
repo dom_collection.CollectionRepository
authFailureRateLimiter ratelimit.AuthFailureRateLimiter
}
func NewUpdateCollectionService(
config *config.Configuration,
logger *zap.Logger,
repo dom_collection.CollectionRepository,
authFailureRateLimiter ratelimit.AuthFailureRateLimiter,
) UpdateCollectionService {
logger = logger.Named("UpdateCollectionService")
return &updateCollectionServiceImpl{
config: config,
logger: logger,
repo: repo,
authFailureRateLimiter: authFailureRateLimiter,
}
}
func (svc *updateCollectionServiceImpl) Execute(ctx context.Context, req *UpdateCollectionRequestDTO) (*CollectionResponseDTO, error) {
//
// STEP 1: Validation
//
if req == nil {
svc.logger.Warn("Failed validation with nil request")
return nil, httperror.NewForBadRequestWithSingleField("non_field_error", "Collection details are required")
}
e := make(map[string]string)
if req.ID.String() == "" {
e["id"] = "Collection ID is required"
}
if req.EncryptedName == "" {
e["encrypted_name"] = "Collection name is required"
}
if req.CollectionType != "" && req.CollectionType != dom_collection.CollectionTypeFolder && req.CollectionType != dom_collection.CollectionTypeAlbum {
e["collection_type"] = "Collection type must be either 'folder' or 'album'"
}
if req.EncryptedCollectionKey == nil {
e["encrypted_collection_key"] = "Encrypted collection key is required"
}
if len(e) != 0 {
svc.logger.Warn("Failed validation",
zap.Any("error", e))
return nil, httperror.NewForBadRequest(&e)
}
//
// STEP 2: Get user ID from context
//
userID, ok := ctx.Value(constants.SessionUserID).(gocql.UUID)
if !ok {
svc.logger.Error("Failed getting user ID from context")
return nil, httperror.NewForInternalServerErrorWithSingleField("message", "Authentication context error")
}
//
// STEP 3: Retrieve existing collection
//
collection, err := svc.repo.Get(ctx, req.ID)
if err != nil {
svc.logger.Error("Failed to get collection",
zap.Any("error", err),
zap.Any("collection_id", req.ID))
return nil, err
}
if collection == nil {
svc.logger.Debug("Collection not found",
zap.Any("collection_id", req.ID))
return nil, httperror.NewForNotFoundWithSingleField("message", "Collection not found")
}
//
// STEP 4: Check rate limiting for authorization failures
//
// Check if user has exceeded authorization failure limits before checking access
if svc.authFailureRateLimiter != nil {
allowed, remainingAttempts, resetTime, err := svc.authFailureRateLimiter.CheckAuthFailure(
ctx,
userID.String(),
req.ID.String(),
"collection:update")
if err != nil {
// Log error but continue - fail open for availability
svc.logger.Error("Failed to check auth failure rate limit",
zap.Error(err),
zap.Any("user_id", userID),
zap.Any("collection_id", req.ID))
} else if !allowed {
svc.logger.Warn("User blocked due to excessive authorization failures",
zap.Any("user_id", userID),
zap.Any("collection_id", req.ID),
zap.Int("remaining_attempts", remainingAttempts),
zap.Time("reset_time", resetTime))
return nil, httperror.NewTooManyRequestsError(
"Too many authorization failures. Please try again later")
}
}
//
// STEP 5: Check if user has rights to update this collection
//
if collection.OwnerID != userID {
// Check if user is a member with admin permissions
isAdmin := false
for _, member := range collection.Members {
if member.RecipientID == userID && member.PermissionLevel == dom_collection.CollectionPermissionAdmin {
isAdmin = true
break
}
}
if !isAdmin {
// Record authorization failure for rate limiting
if svc.authFailureRateLimiter != nil {
if err := svc.authFailureRateLimiter.RecordAuthFailure(
ctx,
userID.String(),
req.ID.String(),
"collection:update",
"insufficient_permission"); err != nil {
svc.logger.Error("Failed to record auth failure",
zap.Error(err),
zap.Any("user_id", userID),
zap.Any("collection_id", req.ID))
}
}
svc.logger.Warn("Unauthorized collection update attempt",
zap.Any("user_id", userID),
zap.Any("collection_id", req.ID))
return nil, httperror.NewForForbiddenWithSingleField("message", "You don't have permission to update this collection")
}
}
// Record successful authorization
if svc.authFailureRateLimiter != nil {
if err := svc.authFailureRateLimiter.RecordAuthSuccess(
ctx,
userID.String(),
req.ID.String(),
"collection:update"); err != nil {
svc.logger.Debug("Failed to record auth success",
zap.Error(err),
zap.Any("user_id", userID),
zap.Any("collection_id", req.ID))
}
}
//
// STEP 6: Check if submitted collection request is in-sync with our backend's collection copy.
//
// Developers note:
// What is the purpose of this check?
// Our server has multiple clients sharing data and hence our backend needs to ensure that the collection being updated is the most recent version.
if collection.Version != req.Version {
svc.logger.Warn("Outdated collection update attempt",
zap.Any("user_id", userID),
zap.Any("collection_id", req.ID),
zap.Any("submitted_version", req.Version),
zap.Any("current_version", collection.Version))
return nil, httperror.NewForBadRequestWithSingleField("message", "Collection has been updated since you last fetched it")
}
//
// STEP 6: Update collection
//
collection.EncryptedName = req.EncryptedName
collection.ModifiedAt = time.Now()
collection.ModifiedByUserID = userID
collection.Version++ // Update mutation means we increment version.
// Only update optional fields if they are provided
if req.CollectionType != "" {
collection.CollectionType = req.CollectionType
}
if req.EncryptedCollectionKey.Ciphertext != nil && len(req.EncryptedCollectionKey.Ciphertext) > 0 &&
req.EncryptedCollectionKey.Nonce != nil && len(req.EncryptedCollectionKey.Nonce) > 0 {
collection.EncryptedCollectionKey = req.EncryptedCollectionKey
}
//
// STEP 7: Save updated collection
//
err = svc.repo.Update(ctx, collection)
if err != nil {
svc.logger.Error("Failed to update collection",
zap.Any("error", err),
zap.Any("collection_id", collection.ID))
return nil, err
}
//
// STEP 8: Map domain model to response DTO
//
ownerEmail := getOwnerEmailFromMembers(collection)
response := mapCollectionToDTO(collection, 0, ownerEmail)
svc.logger.Debug("Collection updated successfully",
zap.Any("collection_id", collection.ID))
return response, nil
}